Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Different Serializing Name #4182

Closed
1 of 2 tasks
zmlcc opened this issue Sep 12, 2024 · 3 comments · Fixed by #4257
Closed
1 of 2 tasks

[Bug] Different Serializing Name #4182

zmlcc opened this issue Sep 12, 2024 · 3 comments · Fixed by #4257
Labels
bug Something isn't working

Comments

@zmlcc
Copy link

zmlcc commented Sep 12, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Paimon version

since 0.8.0

Compute Engine

any

Minimal reproduce step

deletionVectorsRanges is given different serialization name as _DELETION_VECTORS_RANGES In IndexFileMeta and _DELETIONS_VECTORS_RANGES in IndexManifestEntry. This is maybe only an unintentional spelling mistake, but would create potential inconsistencies

What doesn't meet your expectations?

Anything else?

Can we use the same name for serialization ? Should reserve _DELETIONS_VECTORS_RANGES in IndexManifestEntry to keep the index manifest file consistent

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@zmlcc zmlcc added the bug Something isn't working label Sep 12, 2024
@Shadowell
Copy link
Contributor

Reserve _DELETION_VECTORS_RANGES in IndexFileMeta might be better? cc @JingsongLi

@Shadowell
Copy link
Contributor

If this change not to affect future user upgrades, keeping the _DELETIONS_VECTORS_RANGES might be the best option.

@JingsongLi
Copy link
Contributor

If this change not to affect future user upgrades, keeping the _DELETIONS_VECTORS_RANGES might be the best option.

agree with you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants