Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] Automatic closing bracket is missing, when inserting opening bracket #7790

Open
Chris2011 opened this issue Sep 24, 2024 · 2 comments
Open
Labels
kind:feature A feature request needs:triage Requires attention from one of the committers

Comments

@Chris2011
Copy link
Contributor

Description

When I type "export class Test {" and hitting enter, the editor sets the cursor into the correct position but without adding an automatic closing bracket as for JS or other languages.

Use case/motivation

For the first thing I would suggest to do the same as for JS and later on, we can add an option to hit { and it automatically adds a closing bracket as for ( in js. So this should work for normal, array diamond (in the right context) and block brackets.

Related issues

No response

Are you willing to submit a pull request?

Yes

@Chris2011 Chris2011 added kind:feature A feature request needs:triage Requires attention from one of the committers labels Sep 24, 2024
@matthiasblaesing
Copy link
Contributor

This is the behavior of the LSP module. Needs to be checked if it is even possible to configure the typescript LSP, so that it conforms to NB default behavior.

@Chris2011
Copy link
Contributor Author

Yes I thought so too. I think it is not possible to get everything 100% from the LSP so we need to interop with it and extends the stuff. But I dunno yet. I thought I will just add this w/o touching LSP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature A feature request needs:triage Requires attention from one of the committers
Projects
None yet
Development

No branches or pull requests

2 participants