From 7f3b7b8eb7e30824d5b624c1b9a7b2c207f06e99 Mon Sep 17 00:00:00 2001 From: Anton Chernov Date: Wed, 7 Nov 2018 19:10:29 +0100 Subject: [PATCH] [MXNET-969] Fix buffer overflow in RNNOp (v1.3.x) (#13119) * [MXNET-969] Fix buffer overflow in RNNOp Co-authored-by: Sina Md * [MXNET-969] Use ternary op for statecell --- src/operator/rnn-inl.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/operator/rnn-inl.h b/src/operator/rnn-inl.h index 1f905eda4a92..9211f6a456fe 100644 --- a/src/operator/rnn-inl.h +++ b/src/operator/rnn-inl.h @@ -576,7 +576,8 @@ class RNNOp : public Operator{ req[rnn_enum::kData], req[rnn_enum::kParams], req[rnn_enum::kState], - req[rnn_enum::kStateCell], + // State cell should be present for LSTMs, but is absent for other RNNs. + param_.mode == rnn_enum::kLstm ? req[rnn_enum::kStateCell] : kNullOp, param_.p, param_.mode); }