Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite DocValuesFieldExistsQuery to a MatchAllDocsQuery when docCount == maxDoc [LUCENE-10084] #11122

Closed
asfimport opened this issue Sep 2, 2021 · 6 comments

Comments

@asfimport
Copy link

asfimport commented Sep 2, 2021

Now that we require all documents to use the same features (#10374) we could rewrite DocValuesFieldExistsQuery to a MatchAllDocsQuery whenever terms or points have a docCount that is equal to maxDoc.


Migrated from LUCENE-10084 by Adrien Grand (@jpountz), resolved Feb 17 2022
Pull requests: #677

@asfimport
Copy link
Author

Vigya Sharma (@vigyasharma) (migrated from JIRA)

I would like to work on this.

@asfimport
Copy link
Author

Adrien Grand (@jpountz) (migrated from JIRA)

Please feel free to give it a try!

@asfimport
Copy link
Author

Vigya Sharma (@vigyasharma) (migrated from JIRA)

Hi @jpountz, I gave this a try - #677. Is this what you had in mind?

@asfimport
Copy link
Author

asfimport commented Feb 17, 2022

ASF subversion and git services (migrated from JIRA)

Commit c132bbf in lucene's branch refs/heads/main from Vigya Sharma
https://gitbox.apache.org/repos/asf?p=lucene.git;h=c132bbf

LUCENE-10084: Rewrite DocValuesFieldExistsQuery to MatchAllDocsQuery when all docs have the field (#677)

Since all documents are required to use the same features (#10374) we can
rewrite DocValuesFieldExistsQuery to a MatchAllDocsQuery whenever terms or
points have a docCount that is equal to maxDoc.

@asfimport
Copy link
Author

asfimport commented Feb 17, 2022

ASF subversion and git services (migrated from JIRA)

Commit a9532f3 in lucene's branch refs/heads/branch_9x from Vigya Sharma
https://gitbox.apache.org/repos/asf?p=lucene.git;h=a9532f3

LUCENE-10084: Rewrite DocValuesFieldExistsQuery to MatchAllDocsQuery when all docs have the field (#677)

Since all documents are required to use the same features (#10374) we can
rewrite DocValuesFieldExistsQuery to a MatchAllDocsQuery whenever terms or
points have a docCount that is equal to maxDoc.

@asfimport
Copy link
Author

Adrien Grand (@jpountz) (migrated from JIRA)

Closing after the 9.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant