Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] pandas>=0.24.0 datetimelike API changes #6765

Merged
merged 1 commit into from
Jan 28, 2019
Merged

[fix] pandas>=0.24.0 datetimelike API changes #6765

merged 1 commit into from
Jan 28, 2019

Conversation

zihengCat
Copy link
Contributor

The latest released version of pandas v0.24.0 changed datetimelike API. It causes some serious bugs.
Before Superset adapted pandas new API, we should use older version instead, pandas v0.23.4 works fine.
screen shot 2019-01-27 at 12 24 56

Note: pandas what's new in v0.24.0

screen shot 2019-01-27 at 12 11 30

Note: bug occurred inpandas v0.24.0

screen shot 2019-01-27 at 12 11 49

Note: bug fixed in older version of pandas

@codecov-io
Copy link

Codecov Report

Merging #6765 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6765   +/-   ##
=======================================
  Coverage   56.07%   56.07%           
=======================================
  Files         525      525           
  Lines       23220    23220           
  Branches     2777     2777           
=======================================
  Hits        13020    13020           
  Misses       9791     9791           
  Partials      409      409

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62a8d3...ed53133. Read the comment docs.

@mistercrunch
Copy link
Member

Thank you for fixing this. LGTM

@hajdbo
Copy link
Contributor

hajdbo commented Jan 30, 2019

The latest superset release 0.29.0rc7 is broken because of this. Time for a new release?

mistercrunch pushed a commit to mistercrunch/superset that referenced this pull request Jan 30, 2019
jitendra-kumawat added a commit to ThalesGroup/incubator-superset that referenced this pull request Jan 31, 2019
fix pandas version due to  apache#6765

UIC-908
jitendra-kumawat added a commit to ThalesGroup/incubator-superset that referenced this pull request Feb 1, 2019
* feat(db-engines): add support to connect hive db with http transport mode

add support to connect hive db with http transport mode
fix pandas version due to  apache#6765
update libs in setups files
expose all HTTPKerberosAuth class

UIC-908
@kristw kristw added v0.31 !deprecated-label:bug Deprecated label - Use #bug instead install:docker Installation - docker container labels Feb 11, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels !deprecated-label:bug Deprecated label - Use #bug instead install:docker Installation - docker container v0.31 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants