add logging to csv upload #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
reviewed
Nov 8, 2018
| @@ -372,6 +372,7 @@ def form_post(self, form): | |||
| flash( | |||
| message, | |||
| 'danger') | |||
| stats_logger.incr('failed_csv_upload') | |||
There was a problem hiding this comment.
Is there merit in including the sqllab. prefix? Note I'm not sure whether historically we use sqllab or sql_lab.
There was a problem hiding this comment.
per our discussion I think the current state is fine.
timifasubaa
force-pushed
the
log_csv_upload_successes
branch
from
cf5f96b
to
7df8896
Compare
timifasubaa
force-pushed
the
log_csv_upload_successes
branch
from
7df8896
to
a97bce0
Compare
Codecov Report
@@ Coverage Diff @@
## master #6297 +/- ##
=========================================
- Coverage 77.3% 77.3% -0.01%
=========================================
Files 67 67
Lines 9576 9578 +2
=========================================
+ Hits 7403 7404 +1
- Misses 2173 2174 +1
Continue to review full report at Codecov.
|
john-bodley
approved these changes
Nov 8, 2018
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR logs successful vs failed CSV upload attempts
@john-bodley