[reviewable] [refactor] Split visTypes into one file for each visualization type #6290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
changed the title
kristw
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6290 +/- ##
=======================================
Coverage 77.33% 77.33%
=======================================
Files 67 67
Lines 9578 9578
=======================================
Hits 7407 7407
Misses 2171 2171Continue to review full report at Codecov.
|
kristw
changed the title
mistercrunch
reviewed
Nov 8, 2018
kristw
force-pushed
the
kristw-control-panels
branch
from
24b7c33
to
e6ac9a2
Compare
|
LGTM |
williaster
reviewed
Nov 8, 2018
williaster
reviewed
Nov 8, 2018
| @@ -0,0 +1,47 @@ | |||
| import { t } from '@superset-ui/translation'; | |||
| import * as sections from './sections'; | |||
williaster
reviewed
Nov 8, 2018
williaster
reviewed
Nov 8, 2018
| @@ -0,0 +1,52 @@ | |||
| import { t } from '@superset-ui/translation'; | |||
| import * as sections from './sections'; | |||
williaster
reviewed
Nov 8, 2018
williaster
reviewed
Nov 8, 2018
williaster
reviewed
Nov 8, 2018
williaster
reviewed
Nov 8, 2018
williaster
reviewed
Nov 8, 2018
williaster
reviewed
Nov 8, 2018
williaster
reviewed
Nov 8, 2018
| }); | ||
| } | ||
|
|
||
| return [].concat( |
There was a problem hiding this comment.
any reason not to use ... here since you use it for all object spreading?
There was a problem hiding this comment.
Umm, this block of code I didn't touch. It was copy straight from original.
Prefer to leave it the same for now.
williaster
approved these changes
Nov 8, 2018
kristw
force-pushed
the
kristw-control-panels
branch
from
e6ac9a2
to
8cc7529
Compare
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
…zation type (apache#6290) * extract two files * pass linting * rename variables * rename file * fix lint * Rename controlPanelConfigs.js to controlPanels/index.js * use specific imports
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For maintainability, and future compatibility with plugins.
visTypes.jsxtocontrolPanelConfigs.jscontrolPanels/directory.@williaster @conglei @graceguo-supercat @michellethomas @xtinec @mistercrunch