-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix time range filter dropdown #6223
Merged
michellethomas
merged 2 commits into
apache:master
from
michellethomas:fix_time_range_filter_dropdown
Oct 30, 2018
Merged
Fix time range filter dropdown #6223
michellethomas
merged 2 commits into
apache:master
from
michellethomas:fix_time_range_filter_dropdown
Oct 30, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@graceguo-supercat @kristw PR fixes a few issues with the time filter dropdown |
kristw
reviewed
Oct 30, 2018
superset/assets/src/explore/components/controls/DateFilterControl.jsx
Outdated
Show resolved
Hide resolved
superset/assets/src/explore/components/controls/DateFilterControl.jsx
Outdated
Show resolved
Hide resolved
superset/assets/src/explore/components/controls/DateFilterControl.jsx
Outdated
Show resolved
Hide resolved
michellethomas
force-pushed
the
fix_time_range_filter_dropdown
branch
from
October 30, 2018 17:50
24be919
to
3fb0f65
Compare
Codecov Report
@@ Coverage Diff @@
## master #6223 +/- ##
=======================================
Coverage 76.85% 76.85%
=======================================
Files 47 47
Lines 9393 9393
=======================================
Hits 7219 7219
Misses 2174 2174 Continue to review full report at Codecov.
|
kristw
approved these changes
Oct 30, 2018
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 31, 2018
* Fix date filter control dropdown default state * Keep track of selected tab (cherry picked from commit 1c4b3e9)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* Fix date filter control dropdown default state * Keep track of selected tab
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 0.34.0
labels
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When on a chart with custom time range, the time range dropdown doesn't open in the custom tab, it always opens in the default tab. I fixed the issue by moving the logic in
componentDidMount
for setting state tocomponentWillMount
.While looking into that issue, I noticed another. If you start out on the custom tab and go to the default tab where a radio button has already been set, when you hit OK without clicking another button the filter doesn't get updated correctly. The radio buttons only update the
type
field in state if you click a button, so if the value is already selected, it won't change the type. I fixed it by keeping track of the current tab so inclose()
we can use the common filter if the type has not been set but the tab is default.Here's a video of the second issue (the "Last day" filter doesn't get set correctly):
Fixes #6114
@betodealmeida