check db extra and metadata params preemptively #6004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngyjd
force-pushed
the
check-extra-and-metadata-param-preemptively
branch
4 times, most recently
from
c3c20b8
to
3b1fa86
Compare
youngyjd
force-pushed
the
check-extra-and-metadata-param-preemptively
branch
from
3b1fa86
to
41f536a
Compare
Codecov Report
@@ Coverage Diff @@
## master #6004 +/- ##
===========================================
+ Coverage 63.48% 77.82% +14.33%
===========================================
Files 443 46 -397
Lines 23753 9424 -14329
Branches 2638 0 -2638
===========================================
- Hits 15080 7334 -7746
+ Misses 8660 2090 -6570
+ Partials 13 0 -13
Continue to review full report at Codecov.
|
|
@betodealmeida Please take a look |
|
Comments addressed. PTAL @betodealmeida |
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* check db extra and metadata params preemptively * flake8 * make use of inspect
youngyjd
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* check db extra and metadata params preemptively * flake8 * make use of inspect (cherry picked from commit f50ed17)
youngyjd
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* check db extra and metadata params preemptively * flake8 * make use of inspect (cherry picked from commit f50ed17)
youngyjd
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* check db extra and metadata params preemptively * flake8 * make use of inspect (cherry picked from commit f50ed17)
youngyjd
added a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* check db extra and metadata params preemptively * flake8 * make use of inspect (cherry picked from commit f50ed17)
youngyjd
added a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* check db extra and metadata params preemptively * flake8 * make use of inspect (cherry picked from commit f50ed17)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* check db extra and metadata params preemptively * flake8 * make use of inspect
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add a check on extra field and metadata_params on db configuration.