Clean up CONTRIBUTING.md #5911
Merged
Clean up CONTRIBUTING.md #5911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reorganize sections for better navigability - Add table of contents - Rework frontend assets section for clarity and DRY - Rework translating section for clarity, add "Add Translations" contribution type - Move release docs only useful for maintainers to RELEASING.md - Other miscellaneous improvements
|
Thanks for doing this. That file has been evolving without keeping the big picture in mind for a while now! I fixed a merged conflict and re-triggered the build which had a false-negative. |
Codecov Report
@@ Coverage Diff @@
## master #5911 +/- ##
===========================================
+ Coverage 48.22% 63.71% +15.48%
===========================================
Files 393 384 -9
Lines 23596 23545 -51
Branches 2630 2622 -8
===========================================
+ Hits 11379 15001 +3622
+ Misses 12217 8531 -3686
- Partials 0 13 +13
Continue to review full report at Codecov.
|
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
- Reorganize sections for better navigability - Add table of contents - Rework frontend assets section for clarity and DRY - Rework translating section for clarity, add "Add Translations" contribution type - Move release docs only useful for maintainers to RELEASING.md - Other miscellaneous improvements
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md is so large it's hard to read (I spent quite a long time not finding the frontend asset compilation docs), so I made some improvements: