Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] fix redux devtools #5855

Merged
merged 1 commit into from
Sep 11, 2018
Merged

[dev] fix redux devtools #5855

merged 1 commit into from
Sep 11, 2018

Conversation

williaster
Copy link
Contributor

@williaster williaster commented Sep 11, 2018

This PR fixes redux dev tools which broke due to the webpack 4 upgrade.

The process.node. NODE_ENV variable is no longer defined, so I define the new WEBPACK_MODE variable and use its value to set redux dev tools or not.

@kristw @mistercrunch @xtinec @michellethomas @graceguo-supercat

@mistercrunch
Copy link
Member

Oh nice! I noticed this was down a little while ago but never got to fixing it. Thanks for doing this.

@mistercrunch
Copy link
Member

LGTM

@codecov-io
Copy link

codecov-io commented Sep 11, 2018

Codecov Report

Merging #5855 into master will increase coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5855      +/-   ##
==========================================
+ Coverage   63.75%   63.84%   +0.09%     
==========================================
  Files         374      374              
  Lines       23320    23427     +107     
  Branches     2608     2638      +30     
==========================================
+ Hits        14867    14958      +91     
- Misses       8440     8455      +15     
- Partials       13       14       +1
Impacted Files Coverage Δ
superset/assets/src/reduxUtils.js 75.4% <0%> (ø) ⬆️
.../src/explore/components/AdhocMetricEditPopover.jsx 75.91% <0%> (-0.79%) ⬇️
superset/assets/src/SqlLab/actions.js 72.06% <0%> (+0.81%) ⬆️
...rset/assets/src/SqlLab/components/TableElement.jsx 95.23% <0%> (+1.19%) ⬆️
...uperset/assets/src/SqlLab/components/SqlEditor.jsx 80.95% <0%> (+2.85%) ⬆️
superset/assets/src/utils/common.js 65.09% <0%> (+3.55%) ⬆️
...src/explore/components/controls/SpatialControl.jsx 46.95% <0%> (+14.01%) ⬆️
superset/assets/src/common.js 30.76% <0%> (+30.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73db918...043bcfa. Read the comment docs.

@williaster williaster merged commit 1f6e8b3 into master Sep 11, 2018
@williaster williaster deleted the chris--redux-devtools-fix branch September 11, 2018 17:36
kristw pushed a commit to kristw/incubator-superset that referenced this pull request Sep 18, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants