Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sql lab] handle large ints, prevent overflow #5829

Merged
merged 2 commits into from
Sep 11, 2018
Merged

[sql lab] handle large ints, prevent overflow #5829

merged 2 commits into from
Sep 11, 2018

Conversation

mistercrunch
Copy link
Member

No description provided.

mistercrunch
mistercrunch commented Sep 6, 2018
View reviewed changes
superset/assets/spec/javascripts/sqllab/actions_spec.js
@@ -86,13 +86,6 @@ describe('async actions', () => {
expect(dispatch.args[0][0].type).to.equal(actions.START_QUERY);
});

it('calls querySuccess on ajax success', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a dupe to test on line 58

@codecov-io
Copy link

codecov-io commented Sep 6, 2018 •
edited
Loading

Codecov Report

Merging #5829 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5829      +/-   ##
==========================================
- Coverage   63.75%   63.74%   -0.01%     
==========================================
  Files         374      374              
  Lines       23320    23322       +2     
  Branches     2608     2608              
==========================================
  Hits        14867    14867              
- Misses       8440     8442       +2     
  Partials       13       13
Impacted Files Coverage Δ
superset/assets/src/SqlLab/actions.js 70.66% <100%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73db918...ab6bef7. Read the comment docs.

@betodealmeida
Copy link
Member

Nice!

@betodealmeida betodealmeida merged commit 039e7c5 into apache:master Sep 11, 2018
@williaster
Copy link
Contributor

@mistercrunch this has to be adde back to @superset-ui/core now. can you please provide a description of the problem so I can port it / know how to test it properly?

@williaster
Copy link
Contributor

I think the easiest way to support this is by exposing dataType in SupersetClient

@mistercrunch
Copy link
Member Author

@williaster the issue is around JSON parsing when JSON contains big integer. JS does not support large ints and just overflows (number parsed out is different to the number in the JSON).

@mistercrunch
Copy link
Member Author

screen shot 2018-09-12 at 5 29 41 pm

@williaster williaster mentioned this pull request Sep 13, 2018
Merged
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[sql lab] handle large ints, prevent overflow (apache#5829)
5efc01b 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[sql lab] handle large ints, prevent overflow (apache#5829)
ffdf1d7 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[sql lab] handle large ints, prevent overflow (apache#5829)
0e49205 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[sql lab] handle large ints, prevent overflow (apache#5829)
d9ae080 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[sql lab] handle large ints, prevent overflow (apache#5829)
1866478 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[sql lab] handle large ints, prevent overflow (apache#5829)
db653ff 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@mistercrunch @betodealmeida
[sql lab] handle large ints, prevent overflow (apache#5829)
0f49b47 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[sql lab] handle large ints, prevent overflow (apache#5829)
d780e46 
* [sql lab] handle large ints, prevent overflow

* Fix tests
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[sql lab] handle large ints, prevent overflow (apache#5829)
025da42 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[sql lab] handle large ints, prevent overflow (apache#5829)
8220b8f 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[sql lab] handle large ints, prevent overflow (apache#5829)
f4e8b4d 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[sql lab] handle large ints, prevent overflow (apache#5829)
2eaf602 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[sql lab] handle large ints, prevent overflow (apache#5829)
9f3e976 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[sql lab] handle large ints, prevent overflow (apache#5829)
79607db 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
@mistercrunch
[sql lab] handle large ints, prevent overflow (apache#5829)
8789ab8 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[sql lab] handle large ints, prevent overflow (apache#5829)
2dcb40b 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[sql lab] handle large ints, prevent overflow (apache#5829)
dc80eed 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[sql lab] handle large ints, prevent overflow (apache#5829)
c6ac759 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[sql lab] handle large ints, prevent overflow (apache#5829)
41b7541 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[sql lab] handle large ints, prevent overflow (apache#5829)
68103c4 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@mistercrunch @youngyjd
[sql lab] handle large ints, prevent overflow (apache#5829)
b0e102d 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@mistercrunch @youngyjd
[sql lab] handle large ints, prevent overflow (apache#5829)
6098953 
* [sql lab] handle large ints, prevent overflow

* Fix tests

(cherry picked from commit 039e7c5)
(cherry picked from commit 0e49205)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch @betodealmeida
[sql lab] handle large ints, prevent overflow (apache#5829)
0945176 
* [sql lab] handle large ints, prevent overflow

* Fix tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistercrunch @codecov-io @betodealmeida @williaster