Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-5] Refactor Paired t-test #5762

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 28, 2018

  • Extract slice and formData
  • Separate TTestTable component into another file.
  • Some css and js simplification.

image

@williaster @conglei

@codecov-io
Copy link

codecov-io commented Aug 28, 2018

Codecov Report

Merging #5762 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5762      +/-   ##
==========================================
- Coverage    63.7%   63.68%   -0.02%     
==========================================
  Files         366      367       +1     
  Lines       23143    23150       +7     
  Branches     2599     2597       -2     
==========================================
  Hits        14744    14744              
- Misses       8384     8391       +7     
  Partials       15       15
Impacted Files Coverage Δ
...sets/src/visualizations/PairedTTest/TTestTable.jsx 0% <0%> (ø)
...ets/src/visualizations/PairedTTest/PairedTTest.jsx 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eff7a8...751eef5. Read the comment docs.

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, had a couple comments on more specific shapes.

@@ -1,5 +1,5 @@
.paired_ttest .scrollbar-container {
overflow: scroll;
overflow: auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hide all the scroll bars! 🙌

const propTypes = {
className: PropTypes.string,
metrics: PropTypes.arrayOf(PropTypes.string).isRequired,
groups: PropTypes.array.isRequired,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one also PropTypes.arrayOf(PropTypes.string).isRequired?

import './paired_ttest.css';
const propTypes = {
metric: PropTypes.string.isRequired,
groups: PropTypes.array.isRequired,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this also PropTypes.arrayOf(PropTypes.string).isRequired?

const propTypes = {
metric: PropTypes.string.isRequired,
groups: PropTypes.array.isRequired,
data: PropTypes.array.isRequired,
Copy link
Contributor

@williaster williaster Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't quite tell what group is from the code, seems like an array based on this line

[ { group: [array of something?] values: [number, number] } ]

  PropTypes.arrayOf(
    PropTypes.shape({ 
      group: PropTypes.arrayOf(??), 
      values: PropTypes.arrayOf(PropTypes.number), 
    }),
  )

className: PropTypes.string,
metrics: PropTypes.arrayOf(PropTypes.string).isRequired,
groups: PropTypes.array.isRequired,
data: PropTypes.object.isRequired,
Copy link
Contributor

@williaster williaster Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we be more specific about the shape here? I can't quite figure out what group is from the code, seems like an array based on this line

{ my_metric: [ { group: [array of something?] values: [number, number] } ] }

PropTypes.objectOf(
  PropTypes.arrayOf(
    PropTypes.shape({ 
      group: PropTypes.arrayOf(??), 
      values: PropTypes.arrayOf(PropTypes.number), 
    }),
  ),
)

@kristw
Copy link
Contributor Author

kristw commented Sep 5, 2018

Thanks you for catching the PropTypes. Updated accordingly.

@williaster williaster merged commit 68e7794 into apache:master Sep 6, 2018
@kristw kristw deleted the kristw-ttest branch September 7, 2018 00:00
kristw added a commit to kristw/incubator-superset that referenced this pull request Sep 11, 2018
* extract TTestTable into another file.

* Move into directory.

* update proptypes

(cherry picked from commit 68e7794)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* extract TTestTable into another file.

* Move into directory.

* update proptypes
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* extract TTestTable into another file.

* Move into directory.

* update proptypes
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants