Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-6] Refactor WordCloud #5753

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Conversation

conglei
Copy link
Contributor

@conglei conglei commented Aug 28, 2018

This PR moves the backend query data transformation for wordcloud to frontend.

#5692

@williaster @kristw

@codecov-io
Copy link

codecov-io commented Aug 28, 2018

Codecov Report

Merging #5753 into master will decrease coverage by 0.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5753      +/-   ##
==========================================
- Coverage   63.41%   63.39%   -0.02%     
==========================================
  Files         362      362              
  Lines       22993    22993              
  Branches     2558     2558              
==========================================
- Hits        14580    14576       -4     
- Misses       8398     8402       +4     
  Partials       15       15
Impacted Files Coverage Δ
...t/assets/src/visualizations/wordcloud/WordCloud.js 0% <0%> (ø)
superset/viz.py 81.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506cfd1...34b1cf1. Read the comment docs.

@hughhhh hughhhh self-requested a review August 30, 2018 19:57
Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@hughhhh hughhhh merged commit 9f2b502 into apache:master Aug 30, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants