Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump webpack #5744

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Bump webpack #5744

merged 1 commit into from
Aug 27, 2018

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Aug 27, 2018

let's upgrade our webpack package. Things look good on my end developing with the new version. I'm not sure if we had any reason not to update.

@williaster @kristw @mistercrunch

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #5744 into master will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5744      +/-   ##
=========================================
- Coverage   63.45%   62.8%   -0.65%     
=========================================
  Files         362     363       +1     
  Lines       22978   23239     +261     
  Branches     2554    2622      +68     
=========================================
+ Hits        14580   14595      +15     
- Misses       8383    8629     +246     
  Partials       15      15
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 43.25% <0%> (-3.02%) ⬇️
superset/assets/src/visualizations/sunburst.js 0% <0%> (ø) ⬆️
superset/assets/src/visualizations/horizon.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d01c84...4e92b63. Read the comment docs.

@mistercrunch mistercrunch merged commit 46a048b into master Aug 27, 2018
@mistercrunch
Copy link
Member

+1

@mistercrunch mistercrunch deleted the update-webpack branch August 27, 2018 23:59
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants