Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deck arcs] add JS hooks for sourceColor & targetColor #5706

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Aug 23, 2018

Add a color picker for destination color and JS hooks for the mutator function to latch onto

screen shot 2018-08-22 at 5 37 46 pm

@betodealmeida @hughhhh

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #5706 into master will increase coverage by 0.41%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5706      +/-   ##
==========================================
+ Coverage   63.45%   63.86%   +0.41%     
==========================================
  Files         361      361              
  Lines       22972    23501     +529     
  Branches     2557     2609      +52     
==========================================
+ Hits        14576    15010     +434     
- Misses       8381     8476      +95     
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/visualizations/word_cloud.js 0% <ø> (ø) ⬆️
superset/assets/src/explore/visTypes.jsx 62.16% <ø> (+5.01%) ⬆️
superset/assets/src/explore/controls.jsx 42.48% <ø> (-3.79%) ⬇️
...sualizations/deckgl/CategoricalDeckGLContainer.jsx 0% <0%> (ø) ⬆️
...et/assets/src/visualizations/deckgl/layers/arc.jsx 0% <0%> (ø) ⬆️
superset/viz.py 82.74% <0%> (+1.37%) ⬆️
superset/assets/src/visualizations/BigNumber.jsx 1.57% <0%> (+1.57%) ⬆️
superset/models/helpers.py 88.03% <0%> (+2.05%) ⬆️
superset/connectors/sqla/models.py 83% <0%> (+4.37%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8992755...71866f6. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 it, it's beautiful!

@betodealmeida betodealmeida merged commit 1e6a3b0 into apache:master Aug 27, 2018
@mistercrunch mistercrunch deleted the color_arcs branch August 27, 2018 23:58
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
[deck arcs] add JS hooks for sourceColor & targetColor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants