[bugfix] making secondary_metric optional #5682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that `secondary_metric` was required in the chart that users it, namely sunburst, parallel coordinates, and world_map. I set the control as allowing null, and found related bugs in the process: * parallel coordinates did not have support for the new MetricControl * added color scheme support for parallel coordinates * added option to set row_limit on these viz types * sunburst to support numeric columns (number would show as blank)
Codecov Report
@@ Coverage Diff @@
## master #5682 +/- ##
=========================================
- Coverage 63.51% 63.5% -0.01%
=========================================
Files 360 360
Lines 22904 22904
Branches 2551 2555 +4
=========================================
- Hits 14548 14546 -2
- Misses 8341 8343 +2
Partials 15 15
Continue to review full report at Codecov.
|
kristw
pushed a commit
to kristw/incubator-superset
that referenced
this pull request
Aug 22, 2018
I noticed that `secondary_metric` was required in the chart that users it, namely sunburst, parallel coordinates, and world_map. I set the control as allowing null, and found related bugs in the process: * parallel coordinates did not have support for the new MetricControl * added color scheme support for parallel coordinates * added option to set row_limit on these viz types * sunburst to support numeric columns (number would show as blank) (cherry picked from commit 71e0c07)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
I noticed that `secondary_metric` was required in the chart that users it, namely sunburst, parallel coordinates, and world_map. I set the control as allowing null, and found related bugs in the process: * parallel coordinates did not have support for the new MetricControl * added color scheme support for parallel coordinates * added option to set row_limit on these viz types * sunburst to support numeric columns (number would show as blank)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
secondary_metricwas required in the chart that usesit, namely sunburst, parallel coordinates, and world_map.
I set the control as allowing null, and found related bugs in the
process: