-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sql lab] allow EXPlAIN queries #5558
Conversation
7978350
to
b4f7d51
Compare
b4f7d51
to
81a8cc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like a simple PR that requires very little... explaining.
superset/sql_parse.py
Outdated
return self.sql.strip().upper().startswith('EXPLAIN') | ||
|
||
def is_readonly(self): | ||
"""Pessimestic readonly, 100% sure statement won't mutate anything""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Pessimestic/Pessimistic/
Codecov Report
@@ Coverage Diff @@
## master #5558 +/- ##
==========================================
+ Coverage 63.14% 63.26% +0.11%
==========================================
Files 351 351
Lines 22240 22262 +22
Branches 2466 2470 +4
==========================================
+ Hits 14044 14083 +39
+ Misses 8181 8164 -17
Partials 15 15
Continue to review full report at Codecov.
|
* [sql lab] allow EXPlAIN queries closes andialbrecht/sqlparse#421 * typo
closes #5446
related: andialbrecht/sqlparse#421