Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is-react dependency #5478

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Remove is-react dependency #5478

merged 1 commit into from
Jul 25, 2018

Conversation

betodealmeida
Copy link
Member

Turns out this is not needed. Thanks, @williaster!

@betodealmeida betodealmeida mentioned this pull request Jul 24, 2018
Merged
williaster
williaster approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this @betodealmeida! LGTM 🔥

@codecov-io
Copy link

codecov-io commented Jul 24, 2018 •
edited
Loading

Codecov Report

Merging #5478 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5478      +/-   ##
==========================================
- Coverage   59.11%   59.11%   -0.01%     
==========================================
  Files         372      372              
  Lines       23751    23750       -1     
  Branches     2758     2758              
==========================================
- Hits        14041    14040       -1     
  Misses       9695     9695              
  Partials       15       15
Impacted Files Coverage Δ
.../src/explore/components/ControlPanelsContainer.jsx 88.15% <100%> (-0.16%) ⬇️
superset/assets/src/explore/store.js 23.07% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea0a0a...b36ae4d. Read the comment docs.

@mistercrunch mistercrunch merged commit dfb6147 into apache:master Jul 25, 2018
@mistercrunch mistercrunch deleted the remove_is_react branch July 25, 2018 18:02
This was referenced Aug 27, 2018
Closed
Merged
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@betodealmeida @mistercrunch
Remove is-react dep (apache#5478)
67f588c
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betodealmeida @codecov-io @williaster @mistercrunch