Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid expensive select_star on dashboard bootstrap data #5424

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

mistercrunch
Copy link
Member

The dashboard page bootstrap data currently attempts to generate the
SELECT statement with column name details for each table represented
in the dash. This means it calls the database(s) and waits for column
details prior to returning any HTML.

This makes the default select_star property generate a simple
SELECT * with no column details instead, which doesn't require
interogating the DBs.

@betodealmeida

The dashboard page bootstrap data currently attempts to generate the
`SELECT` statement with column name details for each table represented
in the dash. This means it calls the database(s) and waits for column
details prior to returning any HTML.

This makes the default select_star property generate a simple
`SELECT *` with no column details instead, which doesn't require
interogating the DBs.
@codecov-io
Copy link

Codecov Report

Merging #5424 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5424      +/-   ##
==========================================
- Coverage    59.1%   59.09%   -0.02%     
==========================================
  Files         372      372              
  Lines       23747    23747              
  Branches     2758     2758              
==========================================
- Hits        14036    14033       -3     
- Misses       9696     9699       +3     
  Partials       15       15
Impacted Files Coverage Δ
superset/models/core.py 85.83% <ø> (ø) ⬆️
superset/data/__init__.py 100% <100%> (ø) ⬆️
superset/connectors/sqla/models.py 78.01% <100%> (ø) ⬆️
superset/db_engine_specs.py 53.6% <0%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b04b3...e521864. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mistercrunch mistercrunch merged commit 5be0e69 into apache:master Jul 18, 2018
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
The dashboard page bootstrap data currently attempts to generate the
`SELECT` statement with column name details for each table represented
in the dash. This means it calls the database(s) and waits for column
details prior to returning any HTML.

This makes the default select_star property generate a simple
`SELECT *` with no column details instead, which doesn't require
interogating the DBs.
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
The dashboard page bootstrap data currently attempts to generate the
`SELECT` statement with column name details for each table represented
in the dash. This means it calls the database(s) and waits for column
details prior to returning any HTML.

This makes the default select_star property generate a simple
`SELECT *` with no column details instead, which doesn't require
interogating the DBs.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants