[Adhoc Filters] fixing regex displaying as undefined in the pill #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellethomas
approved these changes
Jun 22, 2018
Codecov Report
@@ Coverage Diff @@
## master #5266 +/- ##
=======================================
Coverage 63.28% 63.28%
=======================================
Files 259 259
Lines 19689 19689
Branches 1968 1968
=======================================
Hits 12461 12461
Misses 7219 7219
Partials 9 9
Continue to review full report at Codecov.
|
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the regex operation was used in a filter, the filter's label was not printing properly.
Before:
After:
test plan:
made those screenshots
reviewers:
@michellethomas @john-bodley @graceguo-supercat @mistercrunch