Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timeseries table] use verbose date in tooltip by default #5263

Merged

Conversation

williaster
Copy link
Contributor

When I updated the time series date formatting I failed to use the verbose form in the time series table tooltip.

@john-bodley

@williaster williaster force-pushed the chris--time-table-verbose-tooltip branch from f698137 to e230437 Compare June 21, 2018 18:54
@codecov-io
Copy link

Codecov Report

Merging #5263 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5263   +/-   ##
=======================================
  Coverage   63.28%   63.28%           
=======================================
  Files         259      259           
  Lines       19689    19689           
  Branches     1968     1968           
=======================================
  Hits        12461    12461           
  Misses       7219     7219           
  Partials        9        9
Impacted Files Coverage Δ
superset/assets/src/modules/dates.js 85.91% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb67651...e230437. Read the comment docs.

@williaster williaster merged commit 15c8e5b into apache:master Jun 21, 2018
@williaster williaster deleted the chris--time-table-verbose-tooltip branch June 21, 2018 20:34
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants