Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] get word_cloud to support complex metrics #5248

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

mistercrunch
Copy link
Member

@GabeLoins @graceguo-supercat

@codecov-io
Copy link

Codecov Report

Merging #5248 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5248   +/-   ##
=======================================
  Coverage   60.76%   60.76%           
=======================================
  Files         258      258           
  Lines       19701    19701           
  Branches     1970     1970           
=======================================
  Hits        11972    11972           
  Misses       7720     7720           
  Partials        9        9
Impacted Files Coverage Δ
superset/viz.py 81.34% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70679d4...052dbd2. Read the comment docs.

@hughhhh
Copy link
Member

hughhhh commented Jun 19, 2018

🚢

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mistercrunch mistercrunch merged commit 5a716e9 into apache:master Jun 22, 2018
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants