Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explore] Enable Rich tooltip by default #5215

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jun 15, 2018

per our data scientist requested, want to enable chart's rich tooltip by default.

@mistercrunch @timifasubaa @michellethomas

@codecov-io
Copy link

Codecov Report

Merging #5215 into master will decrease coverage by 14.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5215       +/-   ##
===========================================
- Coverage   77.48%   63.46%   -14.02%     
===========================================
  Files          44      261      +217     
  Lines        8749    19849    +11100     
  Branches        0     1998     +1998     
===========================================
+ Hits         6779    12597     +5818     
- Misses       1970     7243     +5273     
- Partials        0        9        +9
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 44.44% <ø> (ø)
superset/assets/src/visualizations/horizon.js 5.04% <0%> (ø)
...src/explore/components/controls/VizTypeControl.jsx 89.58% <0%> (ø)
...et/assets/src/visualizations/deckgl/layers/hex.jsx 38.46% <0%> (ø)
superset/assets/src/components/PopoverSection.jsx 100% <0%> (ø)
...rset/assets/src/profile/components/TableLoader.jsx 64.7% <0%> (ø)
superset/assets/src/components/FaveStar.jsx 68.75% <0%> (ø)
...ts/src/explore/components/controls/TextControl.jsx 45.45% <0%> (ø)
superset/assets/src/visualizations/world_map.js 21.87% <0%> (ø)
superset/assets/src/modules/AnnotationTypes.js 64% <0%> (ø)
... and 208 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de0aaf4...b4d7827. Read the comment docs.

@hughhhh
Copy link
Member

hughhhh commented Jun 18, 2018

🚢

@graceguo-supercat graceguo-supercat merged commit 0509d7a into apache:master Jun 18, 2018
@graceguo-supercat graceguo-supercat deleted the gg-EnableRichTooltipByDefault branch June 18, 2018 17:46
john-bodley pushed a commit to john-bodley/superset that referenced this pull request Jun 18, 2018
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants