fetch datasources from broker endpoint when refresh new datasources #5183
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5183 +/- ##
=======================================
Coverage 77.46% 77.46%
=======================================
Files 44 44
Lines 8729 8729
=======================================
Hits 6762 6762
Misses 1967 1967
Continue to review full report at Codecov.
|
| def get_pydruid_client(self): | ||
| cli = PyDruid( | ||
| self.get_base_url(self.broker_host, self.broker_port), | ||
| self.broker_endpoint) | ||
| return cli | ||
|
|
||
| def get_datasources(self): | ||
| endpoint = self.get_base_coordinator_url() + '/datasources' | ||
| endpoint = self.get_base_broker_url() + '/datasources' |
There was a problem hiding this comment.
I think get_base_coordinator_url can now be removed. Looks like it's also referenced in tests/druid_tests.py.
|
@mistercrunch Fine, I have updated this PR, please review again, Thx |
|
@mistercrunch Hi, I am confused about the "check failed" on test_urls, why cluster.get_base_broker_url() return "http://localhost:7980/None" |
|
@liyuance add |
|
@mistercrunch, Thx so much! |
|
Do we still need the coordinator for anything? If not we should probably remove it from the model. |
|
Ooops, I merged and then say your comment @john-bodley. I was planning on following up with a PR doing this. |
…pache#5183) * fetch datasources from broker endpoint when refresh new datasources * remove get_base_coordinator_url as out of use * add broker_endpoint in get_test_cluster_obj
…pache#5183) * fetch datasources from broker endpoint when refresh new datasources * remove get_base_coordinator_url as out of use * add broker_endpoint in get_test_cluster_obj
mistercrunch
added
🏷️ bot
We should fetch all datasources from broker endpoint when refresh new datasources.
Otherwise superset will not scan out new datasource unitl new druid supervisor task publish first segment file.