Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving some JS folders #4820

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Moving some JS folders #4820

merged 2 commits into from
Apr 18, 2018

Conversation

mistercrunch
Copy link
Member

javascripts/ -> src/
visualizations/ -> src/visualizations/

I'll be careful to merge instead of squashing as git deals with merge conflicts better when git mv are in different commits than changes in the files somehow.

@codecov-io
Copy link

codecov-io commented Apr 14, 2018

Codecov Report

Merging #4820 into master will increase coverage by 4.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4820      +/-   ##
==========================================
+ Coverage   72.36%   76.98%   +4.61%     
==========================================
  Files         208       44     -164     
  Lines       15662     8498    -7164     
  Branches     1227        0    -1227     
==========================================
- Hits        11334     6542    -4792     
+ Misses       4325     1956    -2369     
+ Partials        3        0       -3
Impacted Files Coverage Δ
superset/assets/javascripts/welcome/index.jsx
...rset/assets/javascripts/welcome/DashboardTable.jsx
superset/assets/javascripts/welcome/App.jsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8669874...cb8d1a2. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mistercrunch mistercrunch merged commit c0db6db into apache:master Apr 18, 2018
@mistercrunch mistercrunch deleted the mv branch April 18, 2018 04:05
boorad pushed a commit to boorad/incubator-superset that referenced this pull request Apr 30, 2018
@joaomg
Copy link
Contributor

joaomg commented May 3, 2018

Ignore, I've seen the commit correcting this.

There's a broken link in static/asset/src/visualizations/country_map.js:
const url = /static/assets/visualizations/countries/${fd.select_country.toLowerCase()}.geojson;
It should be:
const url = /static/assets/src/visualizations/countries/${fd.select_country.toLowerCase()}.geojson;
The country json file won't load.

@mistercrunch
Copy link
Member Author

Fixed on master #4913

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* Moving folders

* Pointing to new locations
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
* Moving folders

* Pointing to new locations
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Moving folders

* Pointing to new locations
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants