[doc] module header for controls.jsx and visTypes.jsx #4777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4777 +/- ##
=======================================
Coverage 72.59% 72.59%
=======================================
Files 205 205
Lines 15401 15401
Branches 1183 1183
=======================================
Hits 11180 11180
Misses 4218 4218
Partials 3 3
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Apr 6, 2018
| @@ -1,3 +1,7 @@ | |||
| /** | |||
| * This file defines how controls (defined in controls.js) are structured into sections | |||
| * | ||
| * While the keys defined in the control itself get passed to the controlType as props, | ||
| * here's a list of the keys that are common to all controls, | ||
| * and as a result define the control interface: |
There was a problem hiding this comment.
The flow of text in lines 12/13 is weird, you might wanna move some of the text in line 13 to line 12.
| and fetch the data | ||
| * - validators: an array of functions that will receive the value of the component and | ||
| should return error messages when the value is not valid. The error message gets | ||
| bubble up to the control header, section header and query panel header. |
| * Note that the keys defined in controls in this file that are not listed above represent | ||
| * props specific for the React component defined as `type`. Also note that this module work | ||
| * in tandem with `visTypes.js` that defines how controls are composed into sections for | ||
| * each and every visualization types. |
There was a problem hiding this comment.
each and every visualization type
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Provide much needed module header for the controls.jsx module * Typos
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
* Provide much needed module header for the controls.jsx module * Typos
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Provide much needed module header for the controls.jsx module * Typos
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.