[dashboard] open in edit mode when adding a chart #4772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4772 +/- ##
==========================================
+ Coverage 72.59% 72.67% +0.08%
==========================================
Files 205 205
Lines 15401 15402 +1
Branches 1183 1183
==========================================
+ Hits 11180 11194 +14
+ Misses 4218 4205 -13
Partials 3 3
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Apr 6, 2018
| @@ -107,7 +107,7 @@ class SaveModal extends React.Component { | |||
| .then((data) => { | |||
| // Go to new slice url or dashboard url | |||
| if (gotodash) { | |||
| window.location = data.dashboard; | |||
| window.location = data.dashboard + '&edit=true'; | |||
There was a problem hiding this comment.
We might wanna use the URL object every where we manipulate URLs to make it more robust, eg:
const url = new URL(data.dashboard);
url.searchParams.set('edit', 'true');
window.location = url.href;
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 11, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* [dashboard] open in edit mode when adding a chart * Move dashboard unit tests to their own file * fix tests * Better URL management
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
* [dashboard] open in edit mode when adding a chart * Move dashboard unit tests to their own file * fix tests * Better URL management
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [dashboard] open in edit mode when adding a chart * Move dashboard unit tests to their own file * fix tests * Better URL management
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.