Docs on how to package a release + CHANGELOG for 0.24.0 #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4697 +/- ##
=======================================
Coverage 71.52% 71.52%
=======================================
Files 190 190
Lines 14927 14927
Branches 1102 1102
=======================================
Hits 10677 10677
Misses 4247 4247
Partials 3 3Continue to review full report at Codecov.
|
xrmx
reviewed
Mar 27, 2018
CONTRIBUTING.md
Outdated
|
|
||
| # publish an update to the CHANGELOG.md for the right version range | ||
| # looking the latest CHANGELOG entry for the second argument | ||
| ./gen_changelog.sh 0.25.0 0.22.1 |
There was a problem hiding this comment.
versions looks reversed, also as an example something like 0.24 0.25 would be easier to follow
There was a problem hiding this comment.
Following the logic in the underlying tool. I don't feel strongly about it either way. npm's github-changes
There was a problem hiding this comment.
From gen_changelog.sh:
# usage: ./github-changes 0.20.0 0.20.1
# will overwrites the local CHANGELOG.md, somehow you need to merge it in
github-changes -o apache -r incubator-superset --token $GITHUB_TOKEN --between-tags $1...$2
So $1 should be older than $2
fabianmenges
approved these changes
Mar 27, 2018
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Apr 10, 2018
* Docs on how to package a release + CHANGELOG for 0.24.0 * Addressing comments * Add pypi perm info (cherry picked from commit deb2111)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Docs on how to package a release + CHANGELOG for 0.24.0 * Addressing comments * Add pypi perm info
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Docs on how to package a release + CHANGELOG for 0.24.0 * Addressing comments * Add pypi perm info
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.