Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: epoch_s and epoch_ms to date time #4664

Merged
merged 1 commit into from
Mar 22, 2018
Merged

fix: epoch_s and epoch_ms to date time #4664

merged 1 commit into from
Mar 22, 2018

Conversation

deatheyes
Copy link
Contributor

fix current usage of to_datetime for epoch_s and epoch_ms
test case:
current:
pd.to_datetime(1521475500, utc=False)
Timestamp('1970-01-01 00:00:01.521475500')
fix:
pd.to_datetime(1521475500, utc=False, unit="s")
Timestamp('2018-03-19 16:05:00')

issue: #4657

doc of 'pd.to_datetime': https://pandas.pydata.org/pandas-docs/stable/generated/pandas.to_datetime.html

@codecov-io
Copy link

codecov-io commented Mar 22, 2018

Codecov Report

Merging #4664 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4664   +/-   ##
=======================================
  Coverage   71.37%   71.37%           
=======================================
  Files         190      190           
  Lines       14918    14918           
  Branches     1102     1102           
=======================================
  Hits        10648    10648           
  Misses       4267     4267           
  Partials        3        3
Impacted Files Coverage Δ
superset/viz.py 79.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec06967...ef5faf3. Read the comment docs.

@mistercrunch
Copy link
Member

super

@mistercrunch mistercrunch merged commit b996523 into apache:master Mar 22, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants