Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mapbox] fix mapbox viz #4621

Merged
merged 1 commit into from
Mar 15, 2018
Merged

[Mapbox] fix mapbox viz #4621

merged 1 commit into from
Mar 15, 2018

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Mar 15, 2018 •
edited
Loading

image

it needs new to call ViewportMercator constructor. otherwise it will throw Cannot call a class as a function error.

@michellethomas @williaster @mistercrunch

@graceguo-supercat graceguo-supercat changed the title fix mapbox viz [Mapbox] fix mapbox viz Mar 15, 2018
@codecov-io
Copy link

codecov-io commented Mar 15, 2018 •
edited
Loading

Codecov Report

Merging #4621 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4621   +/-   ##
=======================================
  Coverage   71.19%   71.19%           
=======================================
  Files         189      189           
  Lines       14843    14843           
  Branches     1088     1088           
=======================================
  Hits        10568    10568           
  Misses       4272     4272           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fa6cd...999d8cb. Read the comment docs.

williaster
williaster approved these changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this ever work?! lgtm.

@graceguo-supercat
Copy link
Author

yeah that's confused me...it just worked before somehow 😕

@graceguo-supercat graceguo-supercat merged commit 7c5bc8d into apache:master Mar 15, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Mar 15, 2018
fix mapbox viz (apache#4621)
c7cc437 
(cherry picked from commit 7c5bc8d)
@graceguo-supercat graceguo-supercat mentioned this pull request Mar 15, 2018
Merged
@fareshan fareshan mentioned this pull request Mar 18, 2018
Closed
@fareshan
Copy link

Hi,
when will this be released ?
and how can i get a version without this issue ?

@fareshan
Copy link

I installed version 0.22.1
It doesn't have this issue.

@graceguo-supercat graceguo-supercat deleted the gg-FixMapboxViz branch March 28, 2018 17:10
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@michellethomas
fix mapbox viz (apache#4621)
f099533
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
fix mapbox viz (apache#4621)
e0c2050
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

@mistercrunch mistercrunch Awaiting requested review from mistercrunch

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@graceguo-supercat @codecov-io @fareshan @williaster @mistercrunch