Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explore] overriding Annotations and Layers' control tab #4609

Merged

Conversation

gabe-lyons
Copy link
Contributor

as reported by @williaster- the annotations and layers control should live in the Data tab and not the Style tab, despite its renderTrigger value. Added this override in.

test plan:

  • visit line chart page
  • expect to see annotations and layers control in the data tab

Reviewers:
@michellethomas
@williaster
@graceguo-supercat

cc
@mistercrunch

@gabe-lyons gabe-lyons force-pushed the gabe_special_casing_annotation_tab branch from 0404b9b to 95ffeea Compare March 13, 2018 22:06
@williaster
Copy link
Contributor

williaster commented Mar 13, 2018

thanks for updating this 🙌 LGTM, only possible suggestion would be making data a variable constant instead for easier re-use ... but as you pointed out re-use may be quite uncommon 😛

@codecov-io
Copy link

codecov-io commented Mar 13, 2018

Codecov Report

Merging #4609 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4609      +/-   ##
==========================================
- Coverage   71.19%   71.19%   -0.01%     
==========================================
  Files         189      189              
  Lines       14840    14843       +3     
  Branches     1086     1088       +2     
==========================================
+ Hits        10566    10568       +2     
- Misses       4271     4272       +1     
  Partials        3        3
Impacted Files Coverage Δ
...set/assets/javascripts/explore/stores/controls.jsx 38.16% <ø> (ø) ⬆️
...ipts/explore/components/ControlPanelsContainer.jsx 86.95% <75%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a9b04...95ffeea. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM

@mistercrunch
Copy link
Member

Wouldn't be against them having their own tab, though that might be a bit much

@williaster williaster merged commit 3371c8b into apache:master Mar 14, 2018
@gabe-lyons
Copy link
Contributor Author

@williaster for simplicity lets keep it as is, if this annotations needs to be used elsewhere I agree we should clean it up.

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants