[sql lab] comment injection hook #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
conn_mutator_2
branch
from
b6c72d8
to
1a083d3
Compare
|
🚢 |
Codecov Report
@@ Coverage Diff @@
## master #4585 +/- ##
==========================================
+ Coverage 71.17% 71.17% +<.01%
==========================================
Files 187 187
Lines 14809 14813 +4
Branches 1085 1085
==========================================
+ Hits 10540 10543 +3
- Misses 4266 4267 +1
Partials 3 3
Continue to review full report at Codecov.
|
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 9, 2018
(cherry picked from commit 34a081b)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us at Lyft to add a comment header that adds metadata to the query to the SQL sent to databases for audit/debug purpose.
Also altering the logic of
DB_CONNECTION_MUTATORto receive the username instead of the user b object, which is out of scope on the worker when running in async mode.