Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove permission check for frontend logging API #4388

Conversation

graceguo-supercat
Copy link

it seems no permission check for logging.

@john-bodley @mistercrunch

@michellethomas
Copy link
Contributor

lgtm

@john-bodley
Copy link
Member

Note @mistercrunch for context we've been running into possible FAB race permission issues again even though we've isolated the updating of FAB permissions, via the SUPERSET_UPDATE_PERMS environment variable, to a single pod.

Regardless given this is a logging endpoint it seems there shouldn't be any permission check.

@graceguo-supercat graceguo-supercat merged commit 5ab4915 into apache:master Feb 8, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Feb 8, 2018
@graceguo-supercat graceguo-supercat deleted the gg-RemovePerssionCheckLogAPI branch February 9, 2018 23:58
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants