Using user-defined Javascript to customize geospatial visualization #4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
js_spatial
branch
3 times, most recently
from
78b267a
to
df22f29
Compare
mistercrunch
force-pushed
the
js_spatial
branch
from
f6a53c6
to
dd1735f
Compare
hughhhh
reviewed
Jan 11, 2018
| const fd = formData; | ||
| const fc = fd.fill_color_picker; | ||
| const sc = fd.stroke_color_picker; | ||
| const data = payload.data.geojson.features.map(d => ({ | ||
| let data = payload.data.geojson.features.map(d => ({ | ||
| ...d, |
There was a problem hiding this comment.
Because now data can be mutated (see below, line 44).
hughhhh
reviewed
Jan 11, 2018
superset/viz.py
Outdated
| @@ -1876,8 +1882,12 @@ def get_data(self, df): | |||
|
|
|||
| features = [] | |||
| for d in df.to_dict(orient='records'): | |||
| d = dict(position=self.get_position(d), **self.get_properties(d)) | |||
| features.append(d) | |||
| print(d) | |||
|
🚢 |
betodealmeida
approved these changes
Jan 11, 2018
superset/viz.py
Outdated
| d['columns'] = [self.form_data.get('line_column')] | ||
| line_col = self.form_data.get('line_column') | ||
| if d['metrics']: | ||
| d['groupby'] += [line_col] |
There was a problem hiding this comment.
shorthand all day 💯 @betodealmeida
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
…pache#4173) * Using JS to customize spatial viz and tooltips * Add missing deck_multi.png * Improve GeoJSON layer with JS support and extra controls * Addressing comments
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…pache#4173) * Using JS to customize spatial viz and tooltips * Add missing deck_multi.png * Improve GeoJSON layer with JS support and extra controls * Addressing comments
3 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept on custom user-provided JS on
deck_pathandeck_scattervisualizations. Users can pick extra data columns that become available in their javascript functions' scope.Users can pass 3 javascript snippet to respectively: