[geo] Added DeckGL GeoJson layer #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
requested changes
Dec 20, 2017
| label: t('Query'), | ||
| expanded: true, | ||
| controlSetRows: [ | ||
| ['geojson'], |
There was a problem hiding this comment.
nit: you can fit those 2 controls on the same row here
| { | ||
| label: t('GeoJson Settings'), | ||
| controlSetRows: [ | ||
| ['fill_color_picker', null], |
There was a problem hiding this comment.
fit 2 color pickers on one row
| @@ -143,6 +143,22 @@ export const controls = { | |||
| renderTrigger: true, | |||
| }, | |||
|
|
|||
| fill_color_picker: { | |||
| label: t('Fill Color'), | |||
| description: t('Use to set fill color of geojson'), | |||
There was a problem hiding this comment.
- t(' Set the opacity to 0 if you do not want to override the color specified in the GeoJSON')
|
|
||
| stroke_color_picker: { | ||
| label: t('Stroke Color'), | ||
| description: t('Use to set stroke color of geojson'), |
There was a problem hiding this comment.
- t(' Set the opacity to 0 if you do not want to override the color specified in the GeoJSON')
superset/data/__init__.py
Outdated
| df = pd.read_json(f) | ||
| df['features'] = df.features.map(json.dumps) | ||
|
|
||
|
|
| const sc = fd.stroke_color_picker; | ||
| const data = payload.data.geojson.features.map(d => ({ | ||
| ...d, | ||
| properties: { |
There was a problem hiding this comment.
this will fully override properties ind d which is not what we want. We should enforce the precedence rule here.
|
The color picker is pretty slow when rendering the change to the canvas. We can do the following:
|
mistercrunch
approved these changes
Dec 22, 2017
|
I think it's a solid start. We can optimize for larger objects later on. |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* added deckgl geojson layer * linting * fixed comments * addressed comments * added override with controls.color_picker > 0 * set var properly * set colors if property doesnt exist at all * refacator on property mapping
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* added deckgl geojson layer * linting * fixed comments * addressed comments * added override with controls.color_picker > 0 * set var properly * set colors if property doesnt exist at all * refacator on property mapping
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DeckGLs GeoJson layer as a new visualization type. Added controls for setting
fillColor,strokeColor, andPoint Radius ScaleFeatures in this PR:
geojson.propertiesobject to DeckGL layergeojson.propertiesfrom controls by setting the opacity(alpha) of the control = 0@mistercrunch