Multi layers DECK.GL visualization #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
multi_deck
branch
3 times, most recently
from
4b5a782
to
d161989
Compare
hughhhh
reviewed
Dec 26, 2017
superset/viz.py
Outdated
| slice_ids = fd.get('deck_slices') | ||
| slices = db.session.query(Slice).filter(Slice.id.in_(slice_ids)).all() | ||
| data = [] | ||
| for slc in slices: |
There was a problem hiding this comment.
nit: data = [slc for slc in slices]
I would even put the [slc for slc in slices] in the actual return statement
return {
'mapboxApiKey': config.get('MAPBOX_API_KEY'),
'slices': [slc for slc in slices],
}
|
LGTM 🚢 |
mistercrunch
force-pushed
the
multi_deck
branch
from
d161989
to
609ba6e
Compare
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Multi layers DECK.GL viz * Fix tests * rebasing * Fix error handling in chartActions * Addressing comments
|
Wanted to confirm if auto-zoom on a multi layer Deck is not supported? Currently layering 2 Scatters does not allow for auto zoom even with conformed column name filters. |
|
Not currently supported as far as I know. |
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Multi layers DECK.GL viz * Fix tests * rebasing * Fix error handling in chartActions * Addressing comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to pile up many DECK.GL slices into a single visualization
fixes #4084