Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better looking favicon #3851

Merged
merged 1 commit into from
Nov 16, 2017
Merged

A better looking favicon #3851

merged 1 commit into from
Nov 16, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Nov 13, 2017

@timifasubaa
Copy link
Contributor

LGTM

@john-bodley
Copy link
Member

Shouldn't the favicon be 16x16 or 32x32 pixels to reduce the payload?

@mistercrunch
Copy link
Member Author

Well with retina now 32 is way too small. It weights 8kb as is and gets cached. Tested it works both on FF and GC

@mistercrunch mistercrunch merged commit fab7b10 into apache:master Nov 16, 2017
@mistercrunch mistercrunch deleted the favicon branch November 16, 2017 18:15
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants