[sql lab] minor cosmetic touchups on Run / Save buttons #3850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
commented
Nov 13, 2017
| @@ -32,10 +32,6 @@ input.form-control { | |||
| background-color: white; | |||
| } | |||
|
|
|||
| input.form-control.input-sm { | |||
There was a problem hiding this comment.
@graceguo-supercat this redefines the theme's input-sm from 30 to 36 which isn't ideal. Yet reverting this doesn't seem to affect react-select in a bad way... Do you more insight as to why this css entry is here?
There was a problem hiding this comment.
Agree. set input-sm from 30 to 36 isn't good. I also fixed in #3852
This was referenced Nov 13, 2017
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: