Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading SQL Lab timeout error message #3825

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

mistercrunch
Copy link
Member

The hint about CTAS is misleading as CTAS will not help. The message is from before when we allowed users to specify whether they wanted sync or async execution or their query, and CTAS meant async. Also did a bit of linting here.

@coveralls
Copy link

coveralls commented Nov 10, 2017

Coverage Status

Coverage increased (+0.004%) to 71.449% when pulling 5dc3149 on mistercrunch:fix_timeout_msg into cbcc00c on apache:master.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit be3da63 into apache:master Nov 10, 2017
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants