Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] VirtualizedSelect for SelectControl and FilterBox #3654

Merged
merged 3 commits into from
Nov 6, 2017
Merged

[Performance] VirtualizedSelect for SelectControl and FilterBox #3654

merged 3 commits into from
Nov 6, 2017

Conversation

Mogball
Copy link
Contributor

@Mogball Mogball commented Oct 12, 2017 •
edited
Loading

#3580

Major changes:

  • improves performance of SelectControl and FilterBox on very large lists by using VirtualizedSelect
  • adds support for handling onPaste to FilterBox
  • onPaste now creates new options from unknown pasted values instead of ignoring them

@coveralls
Copy link

coveralls commented Oct 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.091% when pulling 3504b3d on Mogball:mogball/feature/virtualized_select into 4a3c091 on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.091% when pulling 3504b3d on Mogball:mogball/feature/virtualized_select into 4a3c091 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.091% when pulling 3504b3d on Mogball:mogball/feature/virtualized_select into 4a3c091 on apache:master.

@graceguo-supercat
Copy link

LGTM!

@graceguo-supercat graceguo-supercat merged commit 9a49b1c into apache:master Nov 6, 2017
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@Mogball @michellethomas
[Performance] VirtualizedSelect for SelectControl and FilterBox (apac…
bc67f03 
…he#3654)

* Added virtualized select to SelectControl, allow onPaste to create new options

* Added unit tests

* Added virtualized/paste select to filterbox
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@Mogball
[Performance] VirtualizedSelect for SelectControl and FilterBox (apac…
8a978ec 
…he#3654)

* Added virtualized select to SelectControl, allow onPaste to create new options

* Added unit tests

* Added virtualized/paste select to filterbox
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mogball @coveralls @graceguo-supercat @mistercrunch