Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix]: Explore view does not respect custom timeout. #3582

Merged
merged 1 commit into from
Oct 4, 2017
Merged

[Bugfix]: Explore view does not respect custom timeout. #3582

merged 1 commit into from
Oct 4, 2017

Conversation

fabianmenges
Copy link
Contributor

The Run Query button on the explore view currently ignores custom timeouts. This fixes this.

@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.145% when pulling 595d88b on tc-dc:fmenges/timeout_fix into 18e459e on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.145% when pulling 595d88b on tc-dc:fmenges/timeout_fix into 18e459e on apache:master.

graceguo-supercat
graceguo-supercat approved these changes Oct 3, 2017
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mistercrunch mistercrunch merged commit a85968e into apache:master Oct 4, 2017
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@fabianmenges @michellethomas
[Bugfix]: Explore view does not respect custom timeout. (apache#3582)
595e9cb
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.2 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabianmenges @coveralls @graceguo-supercat @mistercrunch