Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for multiple color schemes #3295

Merged
merged 5 commits into from
Aug 17, 2017

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Aug 15, 2017

  1. create ColorSchemeControl component
  2. using the same new control component for linear colors

for #3258

1. create ColorSchemeControl component
2. using the same new control component for linear colors
@coveralls
Copy link

coveralls commented Aug 15, 2017

Coverage Status

Coverage remained the same at 69.419% when pulling 5dde604 on graceguo-supercat:gg-ColorSchemes into 9c6248f on apache:master.

@coveralls
Copy link

coveralls commented Aug 15, 2017

Coverage Status

Coverage remained the same at 69.419% when pulling 31aeac8 on graceguo-supercat:gg-ColorSchemes into 9c6248f on apache:master.

@coveralls
Copy link

coveralls commented Aug 15, 2017

Coverage Status

Coverage remained the same at 69.419% when pulling 31aeac8 on graceguo-supercat:gg-ColorSchemes into 9c6248f on apache:master.

@coveralls
Copy link

coveralls commented Aug 15, 2017

Coverage Status

Coverage remained the same at 69.419% when pulling 4950be2 on graceguo-supercat:gg-ColorSchemes into 9c6248f on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.419% when pulling 4950be2 on graceguo-supercat:gg-ColorSchemes into 9c6248f on apache:master.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few very minor nits but otherwise this looks solid!

return (
<div>
<ControlHeader {...this.props} />
{selectWrap}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not sure what the value of the selectWrap is, you could just have the <Creatable here

autosize: false,
clearable: false,
onChange: this.onChange,
optionRenderer: opt => this.optionRender(opt.value),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if optionRender expected to receive and option, you could just optionRenderer: this. optionRender here. Also nit could rename to renderOption or optionRenderer

@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Coverage decreased (-0.04%) to 69.378% when pulling f7f4c4a on graceguo-supercat:gg-ColorSchemes into 9c6248f on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 69.378% when pulling f7f4c4a on graceguo-supercat:gg-ColorSchemes into 9c6248f on apache:master.

@mistercrunch mistercrunch merged commit b9a2fa4 into apache:master Aug 17, 2017
@graceguo-supercat graceguo-supercat deleted the gg-ColorSchemes branch August 17, 2017 07:32
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants