Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of Chunked requests #1742

Merged
merged 10 commits into from
Jun 12, 2017

Conversation

nishantmonu51
Copy link
Member

Add fix for handling chunk encoding requests.
If ENABLE_CHUNK_ENCODING is set to true, for requests with transfer
encoding set to true. It will set wsgi.input_terminated to true which
tells werkzeug to ignore content-length and read the stream till the
end.

Fixes #1720

Add fix for handling chunk encoding requests.
If ENABLE_CHUNK_ENCODING is set to true, for requests with transfer
encoding set to true. It will set wsgi.input_terminated to true which
tells werkzeug to ignore content-length and read the stream till the
end.

 break comment in multiple lines
def __call__(self, environ, start_response):
# Setting wsgi.input_terminated tells werkzeug.wsgi to ignore
# content-length and read the stream till the end.
print(environ)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@nishantmonu51
Copy link
Member Author

@xrmx Any more comments ?

@nishantmonu51
Copy link
Member Author

@xrmx: Any more comments on this ?

@xrmx
Copy link
Contributor

xrmx commented Jan 20, 2017

@nishantmonu51 nope, looks fine to me

@nishantmonu51
Copy link
Member Author

@xrmx: can this be merged then ? do i need to contact someone else for getting this in ?

@nishantmonu51
Copy link
Member Author

@mistercrunch: please review.

@mistercrunch
Copy link
Member

LGTM
@nishantmonu51 I granted you write rights on the repo, please confirm by merging the PR!

@mistercrunch mistercrunch merged commit 274d217 into apache:master Jun 12, 2017
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Jun 13, 2017
* Fix handling of Chunked requests

Add fix for handling chunk encoding requests.
If ENABLE_CHUNK_ENCODING is set to true, for requests with transfer
encoding set to true. It will set wsgi.input_terminated to true which
tells werkzeug to ignore content-length and read the stream till the
end.

 break comment in multiple lines

* remove debug print logging
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

superset login is not working when Transfer encoding set to chunked in http request
3 participants