[payload] Set status code on error rather than query status

apache · Mar 7, 2018 · 1e8cd0e · 1e8cd0e
1 parent b63dc91
commit 1e8cd0e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/superset/views/core.py b/superset/views/core.py
@@ -1084,7 +1084,10 @@ def generate_json(self, datasource_type, datasource_id, form_data,
             return json_error_response(utils.error_msg_from_exception(e))
 
         status = 200
-        if payload.get('status') == QueryStatus.FAILED:
+        if (
+            payload.get('status') == QueryStatus.FAILED or
+            payload.get('error') is not None
+        ):
             status = 400
 
         return json_success(viz_obj.json_dumps(payload), status=status)