FC with bias ndim > 1 fails with MKLDNN

[anirudh2290]

Minimum reproducible example:

import numpy as np
import mxnet as mx
from mxnet.test_utils import *
def test_fully_connected():
      data = mx.sym.var("data")
      fc_weight = mx.sym.var("weight")
      fc_bias = mx.sym.var("bias")
      fc = mx.sym.FullyConnected(data=data, weight=fc_weight, bias=fc_bias, num_hidden=10, no_bias=False, name='fc')
      data = mx.nd.random.uniform(shape=(5, 5, 5, 13), dtype=np.float32)
      fc_weight = mx.nd.random.uniform(shape=(10, 325), dtype=np.float32)
      fc_bias = mx.nd.random.uniform(shape=(10), dtype=np.float32)
      fc_bias2 = mx.nd.random.uniform(shape=(10, 1), dtype=np.float32)
      data_np = data.asnumpy().reshape(5, 325)
      fc_weight_np = np.transpose(fc_weight.asnumpy())
      fc_bias_np = fc_bias.asnumpy()
      res = np.dot(data_np, fc_weight_np) + fc_bias.asnumpy()
      check_symbolic_forward(fc, {'data': data_np, 'weight': fc_weight.asnumpy(), 'bias': fc_bias_np}, {'fc_output': res})
      check_numeric_gradient(fc, {'data': data_np, 'weight': fc_weight.asnumpy(), 'bias': fc_bias_np},
                             numeric_eps=1e-2, rtol=1e-4, atol=1e-2)
      # TODO: Fix Bug when bias has ndim > 1
      check_symbolic_forward(fc, {'data': data_np, 'weight': fc_weight.asnumpy(), 'bias': fc_bias2.asnumpy()}, {'fc_output': res})

[mxnet-label-bot]

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels: Bug

[TaoLv]

@anirudh2290 Thank you for reporting. What does the error log look like? And what behavior is expected when bias ndim > 1?

[TaoLv]

@anirudh2290 I see in document bias is defined as 1D with size of num_hidden: https://mxnet.incubator.apache.org/versions/master/api/python/ndarray/ndarray.html#mxnet.ndarray.FullyConnected

[pengzhao-intel]

@anirudh2290 any update? Do we need to fix or close this in 1.5?

[pinaraws]

@mxnet-label-bot remove[Bug]

[pinaraws]

@mxnet-label-bot add[Feature request]

[anirudh2290]

@pengzhao-intel @TaoLv Sorry for the late reply. Thanks for bringing up the documentation. Currnetly it core dumps and better to change it to have a better error message. I would still consider it a bug , although it may be trivial to fix.

[pengzhao-intel]

Thanks for the suggestion. It sounds good and will update the error message.

[pengzhao-intel]

@rongzha1 please take a look for the documentation of FC

[rongzha1]

OK. Will fix in PR 16692

[pengzhao-intel]

fixed and closing