[FLINK-32020] Enable Dynamic Partition Discovery by Default in Kafka Source based on FLIP-288 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Default in Kafka Stream Source based on FLIP-288
… Default in Kafka Table/SQL Source based on FLIP-288
PatrickRen
reviewed
Jul 12, 2023
There was a problem hiding this comment.
@loserwang1024 Thanks for the PR! The logic looks good to me overall. Could you add another test case that validates disabling dynamic partition discovery?
…dynamic partition discovery
PatrickRen
reviewed
Jul 13, 2023
There was a problem hiding this comment.
@loserwang1024 Thanks for the update. I left a tiny comment about the new test case you added.
...ka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/KafkaEnumeratorTest.java
Outdated
Show resolved
Hide resolved
…dynamic partition discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
As described in FLIP-288, dynamic partition discovery is disabled by default, and users have to specify the interval of discovery in order to turn it on. It will be better if enable partition discovery by default.
Brief change log
Verifying this change