Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupedHashAggregateStream should register spillable consumer #8001

Closed
milenkovicm opened this issue Oct 31, 2023 · 0 comments · Fixed by #8002
Closed

GroupedHashAggregateStream should register spillable consumer #8001

milenkovicm opened this issue Oct 31, 2023 · 0 comments · Fixed by #8002
Labels
bug Something isn't working

Comments

@milenkovicm
Copy link
Contributor

Describe the bug

MemoryConsumer for GroupedHashAggregateStream should be with_can_spill=true

change from:

https://github.com/apache/arrow-datafusion/blob/a9d66e2b492843c2fb335a7dfe27fed073629b09/datafusion/physical-plan/src/aggregates/row_hash.rs#L331

to:

let reservation = MemoryConsumer::new(name).with_can_spill(true).register(context.memory_pool());

To Reproduce

No response

Expected behavior

No response

Additional context

Relates to #7858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant