Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Add input type hint to inference model loader #21769

Closed
ryanthompson591 opened this issue Jun 9, 2022 · 1 comment
Closed

[Task]: Add input type hint to inference model loader #21769

ryanthompson591 opened this issue Jun 9, 2022 · 1 comment

Comments

@ryanthompson591
Copy link
Contributor

What needs to happen?

Currently TFX, Scikit learn and Pytorch might get different types of input data.

They then look at the type of input from the pcollection given at run time and decision what sort of path they will go on.

Also these transforms use a large ever expanding list of typehints as the input type.

The ideal way to resolve both these issues would be to allow the user (who should be aware of the input type) a way to pass that in to the model loader (which will return an inferer).

Something like:

model_loader = SklearnModelLoader(url='http://mymodel.com/model.pkl', input_type=pandas.DataFrame)
model_loader = PytorchModelLoader(url='http://mymodel.com/model.pkl', input_type=dict)

Issue Priority
Priority: 2

Issue Component
Component: sdk-py-core

Subtask of issue #21435

Issue Priority

Priority: 2

Issue Component

Component: sdk-py-core

@tvalentyn
Copy link
Contributor

I think this was addressed by introducing separate model loaders: #21803
#21810

Please reopen in there is remaining work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants