[Bug]: Flaky test org.apache.beam.sdk.io.gcp.spanner.SpannerIOWriteExceptionHandlingTest.testExceptionHandlingForWriteGrouped

[nielm]

What happened?

The test org.apache.beam.sdk.io.gcp.spanner.SpannerIOWriteExceptionHandlingTest.testExceptionHandlingForWriteGrouped
(SpannerIOWriteExceptionHandlingTest.java:222) seems to be flaky as a sleeper can be fired more or less times than what is required (I have seen errors with both 8 and 10 times instead of the required 9)

> is a org.mockito.exceptions.verification.TooManyActualInvocations
Stacktrace was: org.mockito.exceptions.verification.TooManyActualInvocations: 
sleeper.sleep(<any long>);
Wanted 9 times:
-> at org.apache.beam.sdk.io.gcp.spanner.SpannerIOWriteExceptionHandlingTest.testExceptionHandlingForWriteGrouped(SpannerIOWriteExceptionHandlingTest.java:222)
But was 10 times:

Issue Priority

Priority: 2

Issue Component

Component: io-java-gcp

[Abacn]

Comment in SpannerIOWriteExceptionHandlingTest says "The default backoff generates about 9 retries, and then errors out the pipeline." This is not always true. FluentBackoff has randomOffset and it may turned out to generate 8 or 10 retries, with total sleep time equals to the max cumulative time (15 min). This makes the tests having a certain probability to fail.

[Abacn]

.take-issue

[Abacn]

duplicates #22008 and there is another solution there